Open
Conversation
Contributor
Author
|
I have incorporated the changes requested in PR #11 |
rousskov
requested changes
Nov 3, 2023
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
Squid wiki (or equivalent) is not the right place for this internal Project documentation. We have https://github.com/squid-cache/ci for this kind of information. Please move this PR there (creating a branch in your own repository this time).
| while a version specific `N-matrix` (e.g. `6-matrix` or `5-matrix`) are used for the stable and old releases | ||
| 1. if these jobs are successful, they will trigger the corresponding tarball creation job | ||
| (e.g. [`website-tarballs-head`](https://build.squid-cache.org/job/website-tarballs-head/) for the `trunk_amd64_matrix`). | ||
| The tarball jobs trust that if they are invoked, it's because the branch has a stable build and testing result. |
Contributor
There was a problem hiding this comment.
For many, "stable result" means "the same result over several tests (including the same failure)". I am guessing that we want to describe a different condition:
Suggested change
| The tarball jobs trust that if they are invoked, it's because the branch has a stable build and testing result. | |
| The tarball creation jobs trust that they are only invoked for the branch that has passed build tests. |
or, more accurately and to the point:
Suggested change
| The tarball jobs trust that if they are invoked, it's because the branch has a stable build and testing result. | |
| The tarball creation jobs do not verify whether the branch passes build tests. |
| - The book [Squid Proxy Server 3.1: Beginner's | ||
| Guide](https://www.packtpub.com/squid-proxy-server-3-1-beginners-guide/book) | ||
| by Kulbir Saini | ||
| - Documentation about how the project's [infrastructure](/ProjectInfrastructure) |
Contributor
There was a problem hiding this comment.
Please use a more specific term than Project Infrastructure. Too many things fall into this category!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start adding documentation about the automations supporting the project